-
-
Notifications
You must be signed in to change notification settings - Fork 252
chore(deps): bump @metamask/snaps-sdk from 9.0.0 to 10.0.0 #7029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
00e54e8 to
a9bfe00
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
a9bfe00 to
9c3bfec
Compare
79e4421 to
382485a
Compare
| "@metamask/base-controller": "^9.0.0", | ||
| "@metamask/messenger": "^0.3.0", | ||
| "@metamask/snaps-sdk": "^9.0.0", | ||
| "@metamask/snaps-sdk": "^10.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dependency version clash with Snaps SDK peers
Bumping @metamask/snaps-sdk to ^10.1.0 creates a version conflict with peer dependency @metamask/snaps-controllers@^14.0.0 which still requires @metamask/snaps-sdk@^9.0.0. This causes both versions to be installed simultaneously, potentially leading to type conflicts, runtime errors from incompatible APIs, and increased bundle size. The same issue affects all packages in this diff that have @metamask/snaps-controllers as a peer dependency.
382485a to
a935843
Compare
| "@metamask/base-controller": "^9.0.0", | ||
| "@metamask/messenger": "^0.3.0", | ||
| "@metamask/snaps-sdk": "^9.0.0", | ||
| "@metamask/snaps-sdk": "^10.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dependency conflict from mixed Snap SDK versions
Bumping @metamask/snaps-sdk to ^10.1.0 while keeping @metamask/snaps-utils at ^11.0.0 creates a dependency conflict. The yarn.lock shows @metamask/snaps-utils@11.0.0 depends on @metamask/snaps-sdk@^9.0.0, causing both SDK versions to be installed. This major version mismatch can lead to runtime errors, type conflicts, and unexpected behavior since version 10.x includes breaking changes.
a935843 to
b840209
Compare
Bumps [@metamask/snaps-sdk](https://github.com/MetaMask/snaps) from 9.0.0 to 10.0.0. - [Release notes](https://github.com/MetaMask/snaps/releases) - [Commits](https://github.com/MetaMask/snaps/compare/@metamask/snaps-sdk@9.0.0...@metamask/snaps-sdk@10.0.0) --- updated-dependencies: - dependency-name: "@metamask/snaps-sdk" dependency-version: 10.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
b840209 to
f51c617
Compare
Bumps @metamask/snaps-sdk from 9.0.0 to 10.0.0.
Commits
93f69e5release:126.0.0(#3662)604e87bchore!: Make interface actions synchronous (#3361)8b4369dperf: Reduce JSON validation during state updates (#3660)0c693f0perf: Simplify JSON-RPC failure validation (#3661)56e8b0achore: Bump@lavamoat/webpackfrom 1.2.0 to 1.5.0 (#3659)f3e64c7feat!: RemoveuseCaip25Permissionfeature flag and enable behaviour by defa...8571a4dperf: Move request inspection outside of the executor (#3356)222928dchore: Bump@metamask/eth-block-trackerfrom 12.0.1 to 12.1.0 (#3654)36f2212chore: Bump@lavamoat/allow-scriptsfrom 3.3.5 to 3.4.0 (#3651)a566abdchore: Fix broken coverage script (#3657)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Bumps
@metamask/snaps-sdkto^10.1.0across multiple packages and updates lockfile sub-dependencies.@metamask/snaps-sdkto^10.1.0inpackages/account-tree-controller,packages/accounts-controller,packages/assets-controllers,packages/gator-permissions-controller,packages/multichain-account-service,packages/multichain-transactions-controller, andpackages/profile-sync-controller.yarn.lockto include@metamask/providers@^22.1.1,@metamask/rpc-errors@^7.0.3, and expand@metamask/utilsrange to include^11.4.2.Written by Cursor Bugbot for commit f51c617. This will update automatically on new commits. Configure here.