Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/account-tree-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"dependencies": {
"@metamask/base-controller": "^9.0.0",
"@metamask/messenger": "^0.3.0",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-sdk": "^10.1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dependency version clash with Snaps SDK peers

Bumping @metamask/snaps-sdk to ^10.1.0 creates a version conflict with peer dependency @metamask/snaps-controllers@^14.0.0 which still requires @metamask/snaps-sdk@^9.0.0. This causes both versions to be installed simultaneously, potentially leading to type conflicts, runtime errors from incompatible APIs, and increased bundle size. The same issue affects all packages in this diff that have @metamask/snaps-controllers as a peer dependency.

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dependency conflict from mixed Snap SDK versions

Bumping @metamask/snaps-sdk to ^10.1.0 while keeping @metamask/snaps-utils at ^11.0.0 creates a dependency conflict. The yarn.lock shows @metamask/snaps-utils@11.0.0 depends on @metamask/snaps-sdk@^9.0.0, causing both SDK versions to be installed. This major version mismatch can lead to runtime errors, type conflicts, and unexpected behavior since version 10.x includes breaking changes.

Fix in Cursor Fix in Web

"@metamask/snaps-utils": "^11.0.0",
"@metamask/superstruct": "^3.1.0",
"@metamask/utils": "^11.8.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/accounts-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"@metamask/keyring-internal-api": "^9.0.0",
"@metamask/keyring-utils": "^3.1.0",
"@metamask/messenger": "^0.3.0",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-sdk": "^10.1.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/superstruct": "^3.1.0",
"@metamask/utils": "^11.8.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/assets-controllers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"@metamask/metamask-eth-abis": "^3.1.1",
"@metamask/polling-controller": "^15.0.0",
"@metamask/rpc-errors": "^7.0.2",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-sdk": "^10.1.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/utils": "^11.8.1",
"@types/bn.js": "^5.1.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/gator-permissions-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@metamask/delegation-core": "^0.2.0",
"@metamask/delegation-deployments": "^0.12.0",
"@metamask/messenger": "^0.3.0",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-sdk": "^10.1.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/utils": "^11.8.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/multichain-account-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@metamask/keyring-snap-client": "^8.0.0",
"@metamask/keyring-utils": "^3.1.0",
"@metamask/messenger": "^0.3.0",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-sdk": "^10.1.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/superstruct": "^3.1.0",
"@metamask/utils": "^11.8.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/multichain-transactions-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@metamask/keyring-snap-client": "^8.0.0",
"@metamask/messenger": "^0.3.0",
"@metamask/polling-controller": "^15.0.0",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-sdk": "^10.1.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/utils": "^11.8.1",
"@types/uuid": "^8.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/profile-sync-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"dependencies": {
"@metamask/base-controller": "^9.0.0",
"@metamask/messenger": "^0.3.0",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-sdk": "^10.1.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/utils": "^11.8.1",
"@noble/ciphers": "^1.3.0",
Expand Down
60 changes: 52 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2421,7 +2421,7 @@ __metadata:
"@metamask/profile-sync-controller": "npm:^26.0.0"
"@metamask/providers": "npm:^22.1.0"
"@metamask/snaps-controllers": "npm:^14.0.1"
"@metamask/snaps-sdk": "npm:^9.0.0"
"@metamask/snaps-sdk": "npm:^10.1.0"
"@metamask/snaps-utils": "npm:^11.0.0"
"@metamask/superstruct": "npm:^3.1.0"
"@metamask/utils": "npm:^11.8.1"
Expand Down Expand Up @@ -2465,7 +2465,7 @@ __metadata:
"@metamask/network-controller": "npm:^25.0.0"
"@metamask/providers": "npm:^22.1.0"
"@metamask/snaps-controllers": "npm:^14.0.1"
"@metamask/snaps-sdk": "npm:^9.0.0"
"@metamask/snaps-sdk": "npm:^10.1.0"
"@metamask/snaps-utils": "npm:^11.0.0"
"@metamask/superstruct": "npm:^3.1.0"
"@metamask/utils": "npm:^11.8.1"
Expand Down Expand Up @@ -2659,7 +2659,7 @@ __metadata:
"@metamask/providers": "npm:^22.1.0"
"@metamask/rpc-errors": "npm:^7.0.2"
"@metamask/snaps-controllers": "npm:^14.0.1"
"@metamask/snaps-sdk": "npm:^9.0.0"
"@metamask/snaps-sdk": "npm:^10.1.0"
"@metamask/snaps-utils": "npm:^11.0.0"
"@metamask/transaction-controller": "npm:^61.1.0"
"@metamask/utils": "npm:^11.8.1"
Expand Down Expand Up @@ -3779,7 +3779,7 @@ __metadata:
"@metamask/delegation-deployments": "npm:^0.12.0"
"@metamask/messenger": "npm:^0.3.0"
"@metamask/snaps-controllers": "npm:^14.0.1"
"@metamask/snaps-sdk": "npm:^9.0.0"
"@metamask/snaps-sdk": "npm:^10.1.0"
"@metamask/snaps-utils": "npm:^11.0.0"
"@metamask/transaction-controller": "npm:^61.1.0"
"@metamask/utils": "npm:^11.8.1"
Expand Down Expand Up @@ -4068,7 +4068,7 @@ __metadata:
"@metamask/messenger": "npm:^0.3.0"
"@metamask/providers": "npm:^22.1.0"
"@metamask/snaps-controllers": "npm:^14.0.1"
"@metamask/snaps-sdk": "npm:^9.0.0"
"@metamask/snaps-sdk": "npm:^10.1.0"
"@metamask/snaps-utils": "npm:^11.0.0"
"@metamask/superstruct": "npm:^3.1.0"
"@metamask/utils": "npm:^11.8.1"
Expand Down Expand Up @@ -4174,7 +4174,7 @@ __metadata:
"@metamask/messenger": "npm:^0.3.0"
"@metamask/polling-controller": "npm:^15.0.0"
"@metamask/snaps-controllers": "npm:^14.0.1"
"@metamask/snaps-sdk": "npm:^9.0.0"
"@metamask/snaps-sdk": "npm:^10.1.0"
"@metamask/snaps-utils": "npm:^11.0.0"
"@metamask/utils": "npm:^11.8.1"
"@ts-bridge/cli": "npm:^0.6.4"
Expand Down Expand Up @@ -4552,7 +4552,7 @@ __metadata:
"@metamask/messenger": "npm:^0.3.0"
"@metamask/providers": "npm:^22.1.0"
"@metamask/snaps-controllers": "npm:^14.0.1"
"@metamask/snaps-sdk": "npm:^9.0.0"
"@metamask/snaps-sdk": "npm:^10.1.0"
"@metamask/snaps-utils": "npm:^11.0.0"
"@metamask/utils": "npm:^11.8.1"
"@noble/ciphers": "npm:^1.3.0"
Expand Down Expand Up @@ -4602,6 +4602,27 @@ __metadata:
languageName: node
linkType: hard

"@metamask/providers@npm:^22.1.1":
version: 22.1.1
resolution: "@metamask/providers@npm:22.1.1"
dependencies:
"@metamask/json-rpc-engine": "npm:^10.0.2"
"@metamask/json-rpc-middleware-stream": "npm:^8.0.6"
"@metamask/object-multiplex": "npm:^2.0.0"
"@metamask/rpc-errors": "npm:^7.0.2"
"@metamask/safe-event-emitter": "npm:^3.1.1"
"@metamask/utils": "npm:^11.0.1"
detect-browser: "npm:^5.2.0"
extension-port-stream: "npm:^4.1.0"
fast-deep-equal: "npm:^3.1.3"
is-stream: "npm:^2.0.0"
readable-stream: "npm:^3.6.2"
peerDependencies:
webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0
checksum: 10/50194c608fb308cee268c6eefb8c8d439a9d07aa41d07cb5ddcd7e706819aea7e746150f32688fe06d20309b49346440855b5d56aacf286b343da6fcb217cc12
languageName: node
linkType: hard

"@metamask/rate-limit-controller@workspace:packages/rate-limit-controller":
version: 0.0.0-use.local
resolution: "@metamask/rate-limit-controller@workspace:packages/rate-limit-controller"
Expand Down Expand Up @@ -4655,6 +4676,16 @@ __metadata:
languageName: node
linkType: hard

"@metamask/rpc-errors@npm:^7.0.3":
version: 7.0.3
resolution: "@metamask/rpc-errors@npm:7.0.3"
dependencies:
"@metamask/utils": "npm:^11.4.2"
fast-safe-stringify: "npm:^2.0.6"
checksum: 10/3eb3e3665aa20566b04788578f93fdbcb2ca41db103f85a00b0002780da1ad5a3f3e9c26e32d9f01b05d7bcf9537091824433c3247e6c7df11ca384627adb809
languageName: node
linkType: hard

"@metamask/safe-event-emitter@npm:^3.0.0, @metamask/safe-event-emitter@npm:^3.1.1":
version: 3.1.1
resolution: "@metamask/safe-event-emitter@npm:3.1.1"
Expand Down Expand Up @@ -4906,6 +4937,19 @@ __metadata:
languageName: node
linkType: hard

"@metamask/snaps-sdk@npm:^10.1.0":
version: 10.1.0
resolution: "@metamask/snaps-sdk@npm:10.1.0"
dependencies:
"@metamask/key-tree": "npm:^10.1.1"
"@metamask/providers": "npm:^22.1.1"
"@metamask/rpc-errors": "npm:^7.0.3"
"@metamask/superstruct": "npm:^3.2.1"
"@metamask/utils": "npm:^11.8.1"
checksum: 10/72b24beda70e2848de308011475b94716109036dba8f8555cefffb0b757415457f5577795581d967279533874d1991a61bf81c8209049f83042c6d3615b52e76
languageName: node
linkType: hard

"@metamask/snaps-sdk@npm:^9.0.0":
version: 9.0.0
resolution: "@metamask/snaps-sdk@npm:9.0.0"
Expand Down Expand Up @@ -5179,7 +5223,7 @@ __metadata:
languageName: unknown
linkType: soft

"@metamask/utils@npm:^11.0.1, @metamask/utils@npm:^11.1.0, @metamask/utils@npm:^11.4.0, @metamask/utils@npm:^11.8.1":
"@metamask/utils@npm:^11.0.1, @metamask/utils@npm:^11.1.0, @metamask/utils@npm:^11.4.0, @metamask/utils@npm:^11.4.2, @metamask/utils@npm:^11.8.1":
version: 11.8.1
resolution: "@metamask/utils@npm:11.8.1"
dependencies:
Expand Down
Loading