block Test2 in tests where Test::More isn't allowed #23874
Merged
+15
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test2 is a real module (even though it has no functionality) so it is confusing to have a test script use the name for an internal test module. Rename the module to avoid the confusion.
Tests in t/ are generally not allowed to use Test::More or related modules. Instead, they are meant to use t/test.pl. There is a porting test to make sure they are not used. Test2 should be blocked in the same places that Test::More is.
haarg
force-pushed
the
haarg/no-test2-for-t
branch
from
22039e4 to
4f1f1e2
Compare
khwilliamson
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in t/ are generally not allowed to use Test::More or related
modules. Instead, they are meant to use t/test.pl. There is a porting
test to make sure they are not used.
Test2 should be blocked in the same places that Test::More is.