Skip to content

block Test2 in tests where Test::More isn't allowed #23874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2025
+15 −15
Merged

block Test2 in tests where Test::More isn't allowed #23874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69d5701
rename internal test module to not be 'Test2'
haarg Oct 23, 2025
4f1f1e2
block Test2 in tests where Test::More isn't allowed
haarg Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions t/op/require_gh20577.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ eval <<'EOF' or die $@;
{
my %fatpacked;

$fatpacked{"Test1.pm"} = <<'TEST1';
package Test1;
$fatpacked{"TestModule1.pm"} = <<'TEST1';
package TestModule1;
sub import {
my $filename = 'Test2.pm';
my $filename = 'TestModule2.pm';
$INC{$filename} = "the_test_file";
}
1;
TEST1

$fatpacked{"Test2.pm"} = <<'TEST2';
package Test2;
use Test1;
$fatpacked{"TestModule2.pm"} = <<'TEST2';
package TestModule2;
use TestModule1;
1;
TEST2

Expand All @@ -45,14 +45,14 @@ TEST2
EOF

ok(UNIVERSAL::isa($INC[0],"FatPacked"), '$INC[0] starts FatPacked');
ok(!exists $INC{"Test1.pm"}, 'Test1.pm not in %INC');
ok(!exists $INC{"Test2.pm"}, 'Test2.pm not in %INC');
my $ok= eval "use Test2; 1";
ok(!exists $INC{"TestModule1.pm"}, 'TestModule1.pm not in %INC');
ok(!exists $INC{"TestModule2.pm"}, 'TestModule2.pm not in %INC');
my $ok= eval "use TestModule2; 1";
my $err= !$ok ? $@ : undef;
is($err,undef,"No error loading Test2");
is($ok,1,"Loaded Test2 successfully");
is($err,undef,"No error loading TestModule2");
is($ok,1,"Loaded TestModule2 successfully");
ok(UNIVERSAL::isa($INC[0],"FatPacked"), '$INC[0] is still FatPacked');
ok(UNIVERSAL::isa($INC{"Test1.pm"},"FatPacked"), '$INC{"Test1.pm"} is still FatPacked');
is($INC{"Test2.pm"},"the_test_file", '$INC{"Test2.pm"} is as expected');
is($INC[0],$INC{"Test1.pm"},'Same object in @INC and %INC');
ok(UNIVERSAL::isa($INC{"TestModule1.pm"},"FatPacked"), '$INC{"TestModule1.pm"} is still FatPacked');
is($INC{"TestModule2.pm"},"the_test_file", '$INC{"TestModule2.pm"} is as expected');
is($INC[0],$INC{"TestModule1.pm"},'Same object in @INC and %INC');
done_testing();
2 changes: 1 addition & 1 deletion t/porting/test_bootstrap.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ while (my $file = <$fh>) {
# but exclude this file from that test.
unlike(
$contents,
qr/use\s+Test::(?:Simple|More)/,
qr/use\s+(?:Test::(?:Simple|More|Builder)|Test2)/,
"$file doesn't use Test::Simple or Test::More"
) unless ($file =~ m|porting/test_bootstrap\.t|);
next unless $file =~ m!^base/! or $file =~ m!^comp!;
Expand Down
Loading