[AXON-1002] Fix the inability to logout from individual sites #879
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomura
requested review from
akalia-atlassian,
bhorai-atl,
bwieger-atlassian-com,
cabella-dot,
om-ukr,
pastelsky and
sdzh-atlassian
as code owners
marcomura
changed the title
|
Very hesitant to merge at this time
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
The existing code doesn't allow to logout from individual sites because it's deleting the credentials of the site the user wants to logout from, causing all sites sharing the same credentials to be logged out as well.
With this change, we simply don't delete the credentials until they are not shared with any other sites.
How Has This Been Tested?
Basic checks:
npm run lintnpm run testmanual tests