[AXON-1002] Fix the inability to logout from individual sites

CHANGELOG.md

@@ -1,5 +1,11 @@
 ### [Report an Issue](https://github.com/atlassian/atlascode/issues)
 
+## What's new in 3.8.16
+
+### Bug Fixes
+
+- Fixed a bug that prevented authenticated sites from being individually logged out, which caused all sites sharing the same credentials to be logged out
+
 ## What's new in 3.8.14
 
 ### Bug Fixes

src/atlclients/authStore.ts

@@ -443,6 +443,16 @@ export class CredentialManager implements Disposable {
         }
     }
 
+    /**
+     * Determines if a site's credential id is shared among other sites
+     * @param site The site for the credential we want to look up
+     * @param allSites All sites (`site` will be excluded from the search)
+     * @returns True if the credential is shared, false otherwise
+     */
+    public isSiteCredentialShared(site: DetailedSiteInfo, allSites: DetailedSiteInfo[]): boolean {
+        return !!allSites.find((x) => x !== site && x.credentialId === site.credentialId);
+    }
+
     /**
      * Removes an auth item from both the in-memory store and the secretstorage.
      */

src/siteManager.test.ts

@@ -64,6 +64,7 @@ describe('SiteManager', () => {
             getAuthInfo: jest.fn(),
             removeAuthInfo: jest.fn(),
             generateCredentialId: jest.fn(),
+            isSiteCredentialShared: jest.fn().mockReturnValue(false),
         } as unknown as CredentialManager;
 
         CredentialManager.generateCredentialId = jest.fn((productKey, userId) => `${productKey}-${userId}`);

src/siteManager.ts

@@ -319,7 +319,14 @@ export class SiteManager extends Disposable {
                 this.resolvePrimarySite();
 
                 if (removeCredentials) {
-                    await Container.credentialManager.removeAuthInfo(deletedSite);
+                    if (
+                        !Container.credentialManager.isSiteCredentialShared(
+                            deletedSite,
+                            this.getSitesAvailable(deletedSite.product),
+                        )
+                    ) {
+                        await Container.credentialManager.removeAuthInfo(deletedSite);
+                    }
                 }
                 if (fireEvent) {
                     this._onDidSitesAvailableChange.fire({