Fix <br> that should be <br/> #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 31, 2022 12:27
Owner
|
I'm not convinced this change is necessary since "void" tags in HTML do not require a slash: https://dev.w3.org/html5/html-author/ Can you please explain what your issue is? |
Author
|
In our case Readium https://github.com/readium/readium-js is unable to validate the xml generated by go-render-quill.
Also you may know that ReactJS doesn’t accept un closed tags.
I suppose it is related to XHTML according to this:
https://www.w3.org/TR/xhtml1/#h-4.6
But if this change causes issue somewhere else then do not merge it we will fork and use our own repo.
… On 4 Apr 2022, at 00:49, Dmitriy ***@***.***> wrote:
I'm not convinced this change is necessary since "void" tags in HTML do not require a slash: https://dev.w3.org/html5/html-author/
Can you please explain what your issue is?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, we use this lib in our project but there is an issue with
<br>that should be<br/>.Fixed in this PR.
Could you test it on your side before to merge?
Romaric