Skip to content

Fix <br> that should be <br/> #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix <br> that should be <br/> #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2540791
Update render_test.go
Mar 31, 2022
d0ea8cb
Update render.go
Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions render.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ func (o *Op) writeBlock(vars *renderVars) {

// Avoid empty paragraphs and "\n" in the output for text blocks.
if o.Data == "" && block.tagName == "p" && vars.tempBuf.Len() == 0 {
o.Data = "<br>"
o.Data = "<br/>"
}

if block.tagName != "" {
Expand All @@ -227,7 +227,7 @@ func (o *Op) writeBlock(vars *renderVars) {

vars.finalBuf.Write(vars.tempBuf.Bytes()) // Copy the temporary buffer to the final output.

vars.finalBuf.WriteString(o.Data) // Copy the data of the current Op (usually just "<br>" or blank).
vars.finalBuf.WriteString(o.Data) // Copy the data of the current Op (usually just "<br/>" or blank).

if block.tagName != "" {
closeTag(&vars.finalBuf, block.tagName)
Expand Down
4 changes: 2 additions & 2 deletions render_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ func TestSimple(t *testing.T) {
}{
"empty": {
ops: `[{"insert": "\n"}]`,
want: "<p><br></p>",
want: "<p><br/></p>",
},
"two paragraphs (single op)": {
ops: `[{"insert": "line1\nline2\n"}]`,
want: "<p>line1</p><p>line2</p>",
},
"blank line": {
ops: `[{"insert": "line1\n\nline3\n"}]`,
want: "<p>line1</p><p><br></p><p>line3</p>",
want: "<p>line1</p><p><br/></p><p>line3</p>",
},
"blockquote": {
ops: `[{"insert": "bkqt"}, {"attributes": {"blockquote": true}, "insert": "\n"}]`,
Expand Down