relax instrumentation matcher #4284
Draft
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
SylvainJuge
reviewed
Oct 30, 2025
| public ElementMatcher<? super TypeDescription> getTypeMatcher() { | ||
| return nameStartsWith("org.springframework.web.servlet") | ||
| .and(hasSuperType(named("org.springframework.web.servlet.HandlerAdapter"))) | ||
| return hasSuperType(named("org.springframework.web.servlet.HandlerAdapter")) |
Member
There was a problem hiding this comment.
Doing that will make the matching expensive as all potential instrumentation candidates will need to have all their super type chain resolved. We could however maybe use getTypeMatcherPreFilter to keep an heuristic on name while not impacting performance too much.
The total matching time is shown in agent debug logs when the agent stops, so that helps to give an idea about the efficiency of the heuristic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying out things for spring web mvc