chore: remove test_flow_worker and add missing anon permissions #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Nov 10, 2025
Closed
Contributor
Author
This was referenced Nov 10, 2025
|
View your CI Pipeline Execution ↗ for commit d93b4fa
☁️ Nx Cloud last updated this comment at |
jumski
force-pushed
the
11-10-feat_demo_-_prepare_final_deployment
branch
from
97a9568 to
cd742df
Compare
jumski
force-pushed
the
11-10-feat_demo_-_fix_the_wider_view
branch
from
3f4a7dc to
c7577a4
Compare
jumski
force-pushed
the
11-10-feat_demo_-_prepare_final_deployment
branch
from
cd742df to
013d6d0
Compare
jumski
force-pushed
the
11-10-feat_demo_-_prepare_final_deployment
branch
from
013d6d0 to
d93b4fa
Compare
Contributor
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-340.pgflow.pages.dev 📝 Details:
_Last updated: _ |
Contributor
🔍 Preview Deployment: Demo✅ Deployment successful! 🔗 Preview URL: https://pr-340-pgflow-demo.jumski.workers.dev 📝 Details:
_Last updated: _ |
This was referenced Nov 11, 2025
Closed
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
# Remove test_flow_worker and improve demo permissions This PR removes the unused `test_flow_worker` function and its associated configuration from the demo app. The function was likely a test implementation that's no longer needed. Key changes: - Removed the `test_flow_worker` function configuration from `config.toml` - Deleted the entire `test_flow_worker` directory and its files - Removed the migration that created the test flow - Added permissions for anon role to view `pgflow.step_tasks` and `pgflow.workers` tables - Added a new migration to clean up orphaned pgmq queues, ensuring a clean slate before flow migrations run The cleanup migration handles cases where DROP EXTENSION pgmq didn't cascade properly by safely removing any orphaned queues and sequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove test_flow_worker and improve demo permissions
This PR removes the unused
test_flow_workerfunction and its associated configuration from the demo app. The function was likely a test implementation that's no longer needed.Key changes:
test_flow_workerfunction configuration fromconfig.tomltest_flow_workerdirectory and its filespgflow.step_tasksandpgflow.workerstablesThe cleanup migration handles cases where DROP EXTENSION pgmq didn't cascade properly by safely removing any orphaned queues and sequences.