Fix openSettings context access #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've mentioned to extension developers already, but it's probably good to follow here as well. Rather than using context to get the activity outside of the callback, We have to use the version provided to the callback. Otherwise when there is an activity state change the context is outdated and the settings dialog won't open, or in some cases cause the app to crash with an exception.
fire-light42
requested changes
Nov 4, 2025
|
|
||
| openSettings = { | ||
| openSettings = { ctx -> | ||
| val activity = ctx as AppCompatActivity |
There was a problem hiding this comment.
This is a a cast that might fail if we change how context is passed. Please use as?
Contributor
Author
There was a problem hiding this comment.
I didn't think it was possible to fail for 2 reasons.
- It's passed as requireContext not to great but doesn't matter because...
- it catches any Throwable so it would handle bad context or failed casting automatically
I mean I can use a check like that but just didn't think we needed to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've mentioned to extension developers already, but it's probably good to follow here as well.
Rather than using context to get the activity outside of the callback, We have to use the version provided to the callback. Otherwise when there is an activity state change the context is outdated and the settings dialog won't open, or in some cases cause the app to crash with an exception.