fix: improve confusing update messaging #1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkov
approved these changes
Oct 30, 2025
cmd/root.go
Outdated
| wf, _, _ := utils.GetWorkflow() | ||
|
|
||
| // If a workflow file is present and specifies that the speakeasyVersion is "latest", don't display update notifications as it will be automatically updated when the command is run. | ||
| if wf != nil && wf.SpeakeasyVersion.String() == "latest" { |
Member
There was a problem hiding this comment.
We'd want to render the update available when a workflow file is present but when we're (for instance) running any non-workflow command? I.e. I think it's only workflow run which has weird output
Member
Author
There was a problem hiding this comment.
Ah fair play - it's only run that does the auto upgrade
Member
Author
There was a problem hiding this comment.
@ThomasRooney bump on the review here ☝🏻
Think my scoping down is the right solution
ThomasRooney
requested changes
Oct 30, 2025
Member
ThomasRooney
left a comment
ThomasRooney
left a comment
There was a problem hiding this comment.
need to scope the change more IMO
bradcypert
approved these changes
Oct 30, 2025
simplesagar
approved these changes
Nov 8, 2025
adaam2
force-pushed
the
fix/update-message
branch
from
c8d293f to
b0808a0
Compare
ThomasRooney
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI confusingly displays two conflicting messages - this is because in the logic for displaying the message "Running with latest Speakeasy version" which is based on looking at the workflow.yaml
speakeasyVersion: latestvalue, we do not actually check that we are on latest before rendering it (you can see from the subsequent screenshot that we do eventually autoupgrade)