Skip to content

fix: improve confusing update messaging #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2025
Merged

fix: improve confusing update messaging #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fac15bc
fix: improve confusing update messaging
adaam2 Oct 30, 2025
afb17c6
fix: remove dupe message
adaam2 Oct 30, 2025
bbf52d5
fix: do not use err
adaam2 Oct 30, 2025
b0808a0
fix: scoping
adaam2 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,13 @@ func checkForUpdate(ctx context.Context, currentVersion, artifactArch string, cm
return
}

wf, _, _ := utils.GetWorkflow()

// If we are running the run command and a workflow file is present and specifies that the speakeasyVersion is "latest", don't display update notifications as it will be automatically updated when the command is run.
if cmd.Name() == "run" && wf != nil && wf.SpeakeasyVersion.String() == "latest" {
return
}

newerVersion, err := updates.GetNewerVersion(ctx, artifactArch, currentVersion)
if err != nil {
return // Don't display error to user
Expand Down
6 changes: 5 additions & 1 deletion internal/model/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,11 @@ func runWithVersionFromWorkflowFile(cmd *cobra.Command) error {
}
desiredVersion = latest.String()

logger.PrintfStyled(styles.DimmedItalic, "Running with latest Speakeasy version\n")
// Check if we're actually running the latest version
currentVersion := events.GetSpeakeasyVersionFromContext(ctx)
if newerVersion, err := updates.GetNewerVersion(ctx, artifactArch, currentVersion); err == nil && newerVersion == nil {
logger.PrintfStyled(styles.DimmedItalic, "Running with latest Speakeasy version\n")
}
} else if desiredVersion == "pinned" {
return ErrPinned
} else {
Expand Down
Loading