RSDK-12500: Link request limit exceeded log to docs #5455
Conversation
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
robot/web/request_counter.go
Outdated
| "go.viam.com/rdk/utils/ssync" | ||
| ) | ||
|
|
||
| const reqLimitExceededURL = "https://docs.viam.com/dev/tools/common-errors/#req-limit-exceeded" |
There was a problem hiding this comment.
| const reqLimitExceededURL = "https://docs.viam.com/dev/tools/common-errors/#req-limit-exceeded" | |
| const reqLimitExceededURL = "https://docs.viam.com/dev/tools/common-errors/#exceeded-request-limit-on-resource" |
That link's anchor seems off.
There was a problem hiding this comment.
I have a pr in the docs to shorten it with a custom id! Wanted to wait till the rdk's log is changed until I make it live
robot/web/web_test.go
Outdated
| test.That(t, status.Convert(err).Code(), test.ShouldEqual, codes.ResourceExhausted) | ||
| test.That(t, err.Error(), test.ShouldEndWith, | ||
| fmt.Sprintf("exceeded request limit 1 on resource %v", keyPrefix)) | ||
| fmt.Sprintf("exceeded request limit 1 on resource %v, see https://docs.viam.com/dev/tools/common-errors/#req-limit-exceeded "+ |
There was a problem hiding this comment.
[nit] Can use the variable here, too.
There was a problem hiding this comment.
I thought it was better practice to leave tests as a string? but can def change if you think its better to use a variable
There was a problem hiding this comment.
better practice to leave tests as a string?
As in, it's better practice to not use string-interpolation/formatting-directives in tests? I hadn't heard that before.
There was a problem hiding this comment.
ok, will update, maybe hallucinated that!
There was a problem hiding this comment.
another option is to use test.ShouldBeError and assert that the error is a RequestLimitExceededError
viambot
added
safe to test
viambot
added
safe to test
5 participants
Adding instructions on how to troubleshoot "request limit exceeded" err because lots of people ask for help w/ it
app/RDK logger:
before:
2025-11-12T15:59:14.028Z WARN rdk web/request_counter.go:146 Request limit exceeded for resource {"method":"/viam.robot.v1.RobotService/GetMachineStatus","resource":"viam.robot.v1.RobotService"}after
2025-11-11T22:24:20.813Z WARN rdk web/request_counter.go:147 Request limit exceeded for method /viam.component.camera.v1.CameraService/GetImages on resource cam.viam.component.camera.v1.CameraService. See https://docs.viam.com/dev/tools/common-errors/#req-limit-exceeded for troubleshooting stepsSDK/CLI:
before:
2025-11-12T15:56:23.797Z ERROR client gosdk/gosdk.go:50 rpc error: code = ResourceExhausted desc = exceeded request limit 1 on resource base-1.viam.component.base.v1.BaseServiceafter:
2025-11-12T15:48:37.111Z ERROR client gosdk/gosdk.go:50 rpc error: code = ResourceExhausted desc = exceeded request limit 1 on resource base-1.viam.component.base.v1.BaseService, see https://docs.viam.com/dev/tools/common-errors/#req-limit-exceeded for troubleshooting steps